summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2014-10-17 22:33:14 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2014-10-17 22:33:14 -0400
commit96139cfbbc1581d6f17b601b37ce9dda88d36322 (patch)
tree2b20b96eb17793f65bc42a5714caa4cd312a2b88
parent0c9391e529c47716274a02e799b587ad108004f7 (diff)
Avoid core dump in _outPathInfo() for Path without a parent RelOptInfo.
Nearly all Paths have parents, but a ResultPath representing an empty FROM clause does not. Avoid a core dump in such cases. I believe this is only a hazard for debugging usage, not for production, else we'd have heard about it before. Nonetheless, back-patch to 9.1 where the troublesome code was introduced. Noted while poking at bug #11703.
-rw-r--r--src/backend/nodes/outfuncs.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index cd6c275c639..01b2d6d2d4a 100644
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -1466,7 +1466,10 @@ _outPathInfo(StringInfo str, Path *node)
{
WRITE_ENUM_FIELD(pathtype, NodeTag);
appendStringInfo(str, " :parent_relids ");
- _outBitmapset(str, node->parent->relids);
+ if (node->parent)
+ _outBitmapset(str, node->parent->relids);
+ else
+ _outBitmapset(str, NULL);
WRITE_FLOAT_FIELD(startup_cost, "%.2f");
WRITE_FLOAT_FIELD(total_cost, "%.2f");
WRITE_NODE_FIELD(pathkeys);