summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2025-08-08 00:27:14 +0200
committerPeter Eisentraut <peter@eisentraut.org>2025-08-08 00:28:58 +0200
commita8b31b160bf643a4a7f590a4375d5d268152bda6 (patch)
tree935ebd6267658f465f68d4fbf4e2b82100b41698
parent22d7833505a50840d0c2f45030408ce827452dc4 (diff)
pg_upgrade: Make format strings consistent
The backport of commit f295494d338 introduced a format string using %m. This is not wrong, since those have been supported since commit d6c55de1f99a, but only commit 2c8118ee5d9 later introduced their use in this file. This use introduces a gratuitously different translatable string and also makes it inconsistent with the rest of the file. To avoid that, switch this back to the old-style strerror() route in the appropriate backbranches
-rw-r--r--src/bin/pg_upgrade/check.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index 6fe282d83c9..ae18e04666f 100644
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -1282,7 +1282,7 @@ check_for_not_null_inheritance(ClusterInfo *cluster)
for (int i = 0; i < ntup; i++)
{
if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL)
- pg_fatal("could not open file \"%s\": %m", output_path);
+ pg_fatal("could not open file \"%s\": %s", output_path, strerror(errno));
if (!db_used)
{
fprintf(script, "In database: %s\n", active_db->db_name);