summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Paquier <michael@paquier.xyz>2021-06-26 12:40:07 +0900
committerMichael Paquier <michael@paquier.xyz>2021-06-26 12:40:07 +0900
commitaa2734f5bcdf7d2860fb6a54104b3ed12573de83 (patch)
tree14bd6de2f4c389f476d496791985ebc802387039
parentf851696a21b2893cd927930bef10c377837c634f (diff)
Remove some useless logs from the TAP tests of pgbench
002_pgbench_no_server was printing some array pointers instead of the actual contents of those arrays for the expected outputs of stdout and stderr for a tested command. This does not add any new information that can help with debugging as the test names allow to track failure locations, if any. This commit simply removes those logs as the rest of the printed information is redundant with command_checks_all(). Per discussion with Andrew Dunstan and Álvaro Herrera. Discussion: https://postgr.es/m/YNXNFaG7IgkzZanD@paquier.xyz Backpatch-through: 11
-rw-r--r--src/bin/pgbench/t/002_pgbench_no_server.pl1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
index 69a6d03bb3f..a2d5c939569 100644
--- a/src/bin/pgbench/t/002_pgbench_no_server.pl
+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -23,7 +23,6 @@ sub pgbench
local $Test::Builder::Level = $Test::Builder::Level + 1;
my ($opts, $stat, $out, $err, $name) = @_;
- print STDERR "opts=$opts, stat=$stat, out=$out, err=$err, name=$name";
command_checks_all([ 'pgbench', split(/\s+/, $opts) ],
$stat, $out, $err, $name);
return;