diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-09-03 16:17:39 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-09-03 16:17:39 -0400 |
| commit | b6cfede8b630db61afa7dd158adde93ba669f429 (patch) | |
| tree | 9e4c2ddb7bf1fa546be4ebba4a162af6a9f7647f | |
| parent | 7c0e1a28ac4596e9ea4d942f213114bd70026d6a (diff) | |
Fix typo in pg_srand48 (srand48 in older branches).
">" should be ">>". This typo results in failure to use all of the bits
of the provided seed.
This might rise to the level of a security bug if we were relying on
srand48 for any security-critical purposes, but we are not --- in fact,
it's not used at all unless the platform lacks srandom(), which is
improbable. Even on such a platform the exposure seems minimal.
Reported privately by Andres Freund.
| -rw-r--r-- | src/port/erand48.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/port/erand48.c b/src/port/erand48.c index 64db7a5376c..f58a9808b41 100644 --- a/src/port/erand48.c +++ b/src/port/erand48.c @@ -92,7 +92,7 @@ srand48(long seed) { _rand48_seed[0] = RAND48_SEED_0; _rand48_seed[1] = (unsigned short) seed; - _rand48_seed[2] = (unsigned short) (seed > 16); + _rand48_seed[2] = (unsigned short) (seed >> 16); _rand48_mult[0] = RAND48_MULT_0; _rand48_mult[1] = RAND48_MULT_1; _rand48_mult[2] = RAND48_MULT_2; |