diff options
| author | Michael Paquier <michael@paquier.xyz> | 2025-09-03 10:20:28 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2025-09-03 10:20:28 +0900 |
| commit | c6ea528b470f45832437f2a937cf2f4483d23737 (patch) | |
| tree | c4e6f282b5ee5806248f4377daa682d2d7b30738 | |
| parent | 229911c4bf9a4acfb2b81cff148fd8391e0a577b (diff) | |
Update outdated references to the SLRU ControlLock
SLRU bank locks are referred as "bank locks" or "SLRU bank locks" in the
code comments. The comments updated in this commit use the latter term.
Oversight in 53c2a97a9266, that has replaced the single ControlLock by
the bank control locks.
Author: Julien Rouhaud <julien.rouhaud@free.fr>
Discussion: https://postgr.es/m/aLUT2UO8RjJOzZNq@jrouhaud
Backpatch-through: 17
| -rw-r--r-- | src/backend/access/transam/slru.c | 10 | ||||
| -rw-r--r-- | src/include/access/slru.h | 2 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c index ca69ee4d4f4..d7ebd889aea 100644 --- a/src/backend/access/transam/slru.c +++ b/src/backend/access/transam/slru.c @@ -400,10 +400,10 @@ SimpleLruZeroPage(SlruCtl ctl, int64 pageno) /* * Assume this page is now the latest active page. * - * Note that because both this routine and SlruSelectLRUPage run with - * ControlLock held, it is not possible for this to be zeroing a page that - * SlruSelectLRUPage is going to evict simultaneously. Therefore, there's - * no memory barrier here. + * Note that because both this routine and SlruSelectLRUPage run with a + * SLRU bank lock held, it is not possible for this to be zeroing a page + * that SlruSelectLRUPage is going to evict simultaneously. Therefore, + * there's no memory barrier here. */ pg_atomic_write_u64(&shared->latest_page_number, pageno); @@ -437,7 +437,7 @@ SimpleLruZeroLSNs(SlruCtl ctl, int slotno) * This is a convenience wrapper for the common case of zeroing a page and * immediately flushing it to disk. * - * Control lock is acquired and released here. + * SLRU bank lock is acquired and released here. */ void SimpleLruZeroAndWritePage(SlruCtl ctl, int64 pageno) diff --git a/src/include/access/slru.h b/src/include/access/slru.h index 20dbd1e0070..8d57753ed01 100644 --- a/src/include/access/slru.h +++ b/src/include/access/slru.h @@ -55,7 +55,7 @@ typedef enum /* * Shared-memory state * - * ControlLock is used to protect access to the other fields, except + * SLRU bank locks are used to protect access to the other fields, except * latest_page_number, which uses atomics; see comment in slru.c. */ typedef struct SlruSharedData |