diff options
| author | Simon Riggs <simon@2ndQuadrant.com> | 2015-06-27 00:47:34 +0100 |
|---|---|---|
| committer | Simon Riggs <simon@2ndQuadrant.com> | 2015-06-27 00:47:34 +0100 |
| commit | ca6a11d785abcb42a96362d87a735b1ed1129074 (patch) | |
| tree | d17cef3d0052d44576c7e43bbd4d30dc944f08d0 | |
| parent | 88fab18a4cf14604d994fbee1cf6bf5c67b166b6 (diff) | |
Avoid hot standby cancels from VAC FREEZE
VACUUM FREEZE generated false cancelations of standby queries on an
otherwise idle master. Caused by an off-by-one error on cutoff_xid
which goes back to original commit.
Backpatch to all versions 9.0+
Analysis and report by Marco Nenciarini
Bug fix by Simon Riggs
| -rw-r--r-- | src/backend/access/heap/heapam.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index 2a494f59f4c..44ef948f504 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -4725,7 +4725,13 @@ heap_xlog_freeze(XLogRecPtr lsn, XLogRecord *record) * consider the frozen xids as running. */ if (InHotStandby) - ResolveRecoveryConflictWithSnapshot(cutoff_xid, xlrec->node); + { + TransactionId latestRemovedXid = cutoff_xid; + + TransactionIdRetreat(latestRemovedXid); + + ResolveRecoveryConflictWithSnapshot(latestRemovedXid, rnode); + } /* If we have a full-page image, restore it and we're done */ if (record->xl_info & XLR_BKP_BLOCK(0)) |