diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2023-12-01 14:58:40 +1300 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2023-12-01 15:19:28 +1300 |
| commit | cf84755575d1052770e92d291d1427720c8b53ca (patch) | |
| tree | 9adde2fc076995e644847a9d42cb1015a4dd7b4e | |
| parent | 1f5e38847b26265c15bf367de516b46491c3a7c3 (diff) | |
Adjust obsolete comment explaining set_stack_base().
Commit 7389aad6 removed the notion of backends started from inside a
signal handler. A stray comment still referred to them, while
explaining the need for a call to set_stack_base(). That leads to the
question of whether we still need the call in !EXEC_BACKEND builds.
There doesn't seem to be much point in suppressing it now, as it doesn't
hurt and probably helps to measure the stack base from the exact same
place in EXEC_BACKEND and !EXEC_BACKEND builds.
Back-patch to 16.
Reported-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reported-by: Tristan Partin <tristan@neon.tech>
Reported-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA%2BhUKG%2BEJHcevNGNOxVWxTNFbuB%3Dvjf4U68%2B85rAC_Sxvy2zEQ%40mail.gmail.com
| -rw-r--r-- | src/backend/utils/init/miscinit.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/backend/utils/init/miscinit.c b/src/backend/utils/init/miscinit.c index 0e4942578bf..b0ca61a8d66 100644 --- a/src/backend/utils/init/miscinit.c +++ b/src/backend/utils/init/miscinit.c @@ -107,9 +107,8 @@ InitPostmasterChild(void) /* * Set reference point for stack-depth checking. This might seem - * redundant in !EXEC_BACKEND builds; but it's not because the postmaster - * launches its children from signal handlers, so we might be running on - * an alternative stack. + * redundant in !EXEC_BACKEND builds, but it's better to keep the depth + * logic the same with and without that build option. */ (void) set_stack_base(); |