diff options
| author | Daniel Gustafsson <dgustafsson@postgresql.org> | 2024-02-29 12:19:52 +0100 |
|---|---|---|
| committer | Daniel Gustafsson <dgustafsson@postgresql.org> | 2024-02-29 12:19:52 +0100 |
| commit | d5c3d6ca0152b8ea4870effcd49521e4f767ccac (patch) | |
| tree | addda6cb62fa7393d176b1fb23663538b8db1883 | |
| parent | 43cca9de9a0adf3fb47aaa6310cc0022a78eee8a (diff) | |
Fix integer underflow in shared memory debugging
dsa_dump would print a large negative number instead of zero for
segment bin 0. Fix by explicitly checking for underflow and add
special case for bin 0. Backpatch to all supported versions.
Author: Ian Ilyasov <ianilyasov@outlook.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://postgr.es/m/GV1P251MB1004E0D09D117D3CECF9256ECD502@GV1P251MB1004.EURP251.PROD.OUTLOOK.COM
Backpatch-through: v12
| -rw-r--r-- | src/backend/utils/mmgr/dsa.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/src/backend/utils/mmgr/dsa.c b/src/backend/utils/mmgr/dsa.c index 37da990e62b..6603acf1966 100644 --- a/src/backend/utils/mmgr/dsa.c +++ b/src/backend/utils/mmgr/dsa.c @@ -1093,9 +1093,13 @@ dsa_dump(dsa_area *area) { dsa_segment_index segment_index; - fprintf(stderr, - " segment bin %zu (at least %d contiguous pages free):\n", - i, 1 << (i - 1)); + if (i == 0) + fprintf(stderr, + " segment bin %zu (no contiguous free pages):\n", i); + else + fprintf(stderr, + " segment bin %zu (at least %d contiguous pages free):\n", + i, 1 << (i - 1)); segment_index = area->control->segment_bins[i]; while (segment_index != DSA_SEGMENT_INDEX_NONE) { |