summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2022-06-01 17:21:45 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2022-06-01 17:21:45 -0400
commitdd672be38d39ade3f5bbfaf613e584dc5786ae6d (patch)
treec848f98065afd16f0a3d783aff5bc5392c23e6a3
parentc08538734522f27646dd5fe68d61e16a59477f6e (diff)
Silence compiler warnings from some older compilers.
Since a117cebd6, some older gcc versions issue "variable may be used uninitialized in this function" complaints for brin_summarize_range. Silence that using the same coding pattern as in bt_index_check_internal; arguably, a117cebd6 had too narrow a view of which compilers might give trouble. Nathan Bossart and Tom Lane. Back-patch as the previous commit was. Discussion: https://postgr.es/m/20220601163537.GA2331988@nathanxps13
-rw-r--r--contrib/amcheck/verify_nbtree.c2
-rw-r--r--src/backend/access/brin/brin.c6
2 files changed, 7 insertions, 1 deletions
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
index cb6475d41f0..1a0606704ab 100644
--- a/contrib/amcheck/verify_nbtree.c
+++ b/contrib/amcheck/verify_nbtree.c
@@ -263,7 +263,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed,
else
{
heaprel = NULL;
- /* for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 */
+ /* Set these just to suppress "uninitialized variable" warnings */
save_userid = InvalidOid;
save_sec_context = -1;
save_nestlevel = -1;
diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index 781cac25d82..d9573bece70 100644
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -919,7 +919,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)
save_nestlevel = NewGUCNestLevel();
}
else
+ {
heapRel = NULL;
+ /* Set these just to suppress "uninitialized variable" warnings */
+ save_userid = InvalidOid;
+ save_sec_context = -1;
+ save_nestlevel = -1;
+ }
indexRel = index_open(indexoid, ShareUpdateExclusiveLock);