diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2024-09-13 16:16:47 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2024-09-13 16:16:47 -0400 |
| commit | e0857898b87b745235e65c28feed6e23e121876d (patch) | |
| tree | 5ca3d332e58b3a924f34ba79ac137f0f39eb5123 | |
| parent | a63aef5e496c1db0325845892d946e8569e7f9d6 (diff) | |
Allow _h_indexbuild() to be interrupted.
When we are building a hash index that is large enough to need
pre-sorting (larger than either maintenance_work_mem or NBuffers),
the initial sorting phase is interruptible, but the insertion
phase wasn't. Add the missing CHECK_FOR_INTERRUPTS().
Per bug #18616 from Alexander Lakhin. Back-patch to all
supported branches.
Pavel Borisov
Discussion: https://postgr.es/m/18616-acbb9e5caf41e964@postgresql.org
| -rw-r--r-- | src/backend/access/hash/hashsort.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/access/hash/hashsort.c b/src/backend/access/hash/hashsort.c index aa61e39f26a..bd59ff86f55 100644 --- a/src/backend/access/hash/hashsort.c +++ b/src/backend/access/hash/hashsort.c @@ -146,6 +146,9 @@ _h_indexbuild(HSpool *hspool, Relation heapRel) _hash_doinsert(hspool->index, itup, heapRel); + /* allow insertion phase to be interrupted, and track progress */ + CHECK_FOR_INTERRUPTS(); + pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE, ++tups_done); } |