summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2024-03-20 15:28:14 +0100
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2024-03-20 15:28:14 +0100
commite6c4e01bf4405ea779ec0b942d7eaa81e18423e1 (patch)
treeddeb2f1b97390880caedd3444d290549e833c44f
parent1f4eb734200a2420f45d0204d95b65ddf707888c (diff)
Review wording on tablespaces w.r.t. partitioned tables
Remove a redundant comment, and document pg_class.reltablespace properly in catalogs.sgml. After commits a36c84c3e4a9, 87259588d0ab and others. Backpatch to 12. Discussion: https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql
-rw-r--r--doc/src/sgml/catalogs.sgml9
-rw-r--r--src/backend/commands/tablecmds.c4
2 files changed, 6 insertions, 7 deletions
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 43cccb43d62..4945d4bc6e8 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -2010,9 +2010,12 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)
</para>
<para>
- The tablespace in which this relation is stored. If zero,
- the database's default tablespace is implied. (Not meaningful
- if the relation has no on-disk file.)
+ The tablespace in which this relation is stored.
+ If zero, the database's default tablespace is implied.
+ Not meaningful if the relation has no on-disk file,
+ except for partitioned tables, where this is the tablespace
+ in which partitions will be created when one is not
+ specified in the creation command.
</para></entry>
</row>
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 9cabdfe668a..6f854c187ad 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -785,10 +785,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
}
else if (stmt->partbound)
{
- /*
- * For partitions, when no other tablespace is specified, we default
- * the tablespace to the parent partitioned table's.
- */
Assert(list_length(inheritOids) == 1);
tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));
}