diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2016-12-16 12:50:20 +0200 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2016-12-16 12:53:22 +0200 |
| commit | e71fe84708174b3ae56add6d2ad98e9c91f84589 (patch) | |
| tree | f6054cb38078e4bdedee23cdd126a865103bd7d2 | |
| parent | ccf24539b6bf23345c57b76749b84c9af31ca8a5 (diff) | |
Fix off-by-one in memory allocation for quote_literal_cstr().
The calculation didn't take into account the NULL terminator. That lead
to overwriting the palloc'd buffer by one byte, if the input consists
entirely of backslashes. For example "format('%L', E'\\')".
Fixes bug #14468. Backpatch to all supported versions.
Report: https://www.postgresql.org/message-id/20161216105001.13334.42819%40wrigleys.postgresql.org
| -rw-r--r-- | src/backend/utils/adt/quote.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/utils/adt/quote.c b/src/backend/utils/adt/quote.c index dc742b5f911..19ce8a25ba4 100644 --- a/src/backend/utils/adt/quote.c +++ b/src/backend/utils/adt/quote.c @@ -107,7 +107,7 @@ quote_literal_cstr(const char *rawstr) len = strlen(rawstr); /* We make a worst-case result area; wasting a little space is OK */ - result = palloc(len * 2 + 3); + result = palloc(len * 2 + 3 + 1); newlen = quote_literal_internal(result, rawstr, len); result[newlen] = '\0'; |