diff options
| author | Michael Paquier <michael@paquier.xyz> | 2021-11-24 20:12:54 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2021-11-24 20:12:54 +0900 |
| commit | f79962d8264b8d205ce45a8aa11d1b37f9592a81 (patch) | |
| tree | b6643cd8bb2e70047f7f7b7e9006cc616b21b87a | |
| parent | 411137a429210e432f923264a8e313a9872910ca (diff) | |
Remove useless LZ4 system call on failure when writing file header
If an error occurs when writing the LZ4 file header, LZ4F_compressEnd()
was called in the error code path of write(), followed by
LZ4F_freeCompressionContext() to finish the cleanup. The code as-is was
not broken, but the LZ4F_compressEnd() proves to not be necessary as
there are no contents to flush at this stage, so remove it.
Per gripe from Jeevan Ladhe and Robert Haas.
Discussion: https://postgr.es/m/CAOgcT0PE33wbD7giAT1OSkNJt=p-vu8huq++qh=ny9O=SCP5aA@mail.gmail.com
| -rw-r--r-- | src/bin/pg_basebackup/walmethods.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c index fe6b034637a..affdc5055fb 100644 --- a/src/bin/pg_basebackup/walmethods.c +++ b/src/bin/pg_basebackup/walmethods.c @@ -193,7 +193,6 @@ dir_open_for_write(const char *pathname, const char *temp_suffix, size_t pad_to_ { /* If write didn't set errno, assume problem is no disk space */ dir_data->lasterrno = errno ? errno : ENOSPC; - (void) LZ4F_compressEnd(ctx, lz4buf, lz4bufsize, NULL); (void) LZ4F_freeCompressionContext(ctx); pg_free(lz4buf); close(fd); |