diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2021-04-07 14:33:21 +0300 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2021-04-07 14:33:21 +0300 |
| commit | d92b1cdbab408d8f1299257125c9ae375f3ca644 (patch) | |
| tree | e75e26cae720ad2f4a0e1d8ef071ae197924c45a /contrib/btree_gist/btree_date.c | |
| parent | 9f984ba6d23dc6eecebf479ab1d3f2e550a4e9be (diff) | |
Revert "Add sortsupport for gist_btree opclasses, for faster index builds."
This reverts commit 9f984ba6d23dc6eecebf479ab1d3f2e550a4e9be.
It was making the buildfarm unhappy, apparently setting client_min_messages
in a regression test produces different output if log_statement='all'.
Another issue is that I now suspect the bit sortsupport function was in
fact not correct to call byteacmp(). Revert to investigate both of those
issues.
Diffstat (limited to 'contrib/btree_gist/btree_date.c')
| -rw-r--r-- | contrib/btree_gist/btree_date.c | 27 |
1 files changed, 0 insertions, 27 deletions
diff --git a/contrib/btree_gist/btree_date.c b/contrib/btree_gist/btree_date.c index 3abb6e9c475..455a265a497 100644 --- a/contrib/btree_gist/btree_date.c +++ b/contrib/btree_gist/btree_date.c @@ -25,7 +25,6 @@ PG_FUNCTION_INFO_V1(gbt_date_consistent); PG_FUNCTION_INFO_V1(gbt_date_distance); PG_FUNCTION_INFO_V1(gbt_date_penalty); PG_FUNCTION_INFO_V1(gbt_date_same); -PG_FUNCTION_INFO_V1(gbt_date_sortsupport); static bool gbt_dategt(const void *a, const void *b, FmgrInfo *flinfo) @@ -258,29 +257,3 @@ gbt_date_same(PG_FUNCTION_ARGS) *result = gbt_num_same((void *) b1, (void *) b2, &tinfo, fcinfo->flinfo); PG_RETURN_POINTER(result); } - -static int -gbt_date_sort_build_cmp(Datum a, Datum b, SortSupport ssup) -{ - dateKEY *ia = (dateKEY *) PointerGetDatum(a); - dateKEY *ib = (dateKEY *) PointerGetDatum(b); - - return DatumGetInt32(DirectFunctionCall2(date_cmp, - DateADTGetDatum(ia->lower), - DateADTGetDatum(ib->lower))); -} - -/* - * Sort support routine for fast GiST index build by sorting. - */ -Datum -gbt_date_sortsupport(PG_FUNCTION_ARGS) -{ - SortSupport ssup = (SortSupport) PG_GETARG_POINTER(0); - - ssup->comparator = gbt_date_sort_build_cmp; - ssup->abbrev_converter = NULL; - ssup->abbrev_abort = NULL; - ssup->abbrev_full_comparator = NULL; - PG_RETURN_VOID(); -} |