diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-06 22:14:07 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2015-08-06 22:14:07 -0400 |
| commit | de5edc660ae09e9a2785e52d2b539f2e0def1e63 (patch) | |
| tree | 6e1365e3dcee87001d4cb4d0e82fb0d1d399c024 /contrib/btree_gist/btree_utils_num.h | |
| parent | 0d4913509b0becfd3db3fe9d0266b0ecdf0b3334 (diff) | |
Fix old oversight in join removal logic.
Commit 9e7e29c75ad441450f9b8287bd51c13521641e3b introduced an Assert that
join removal didn't reduce the eval_at set of any PlaceHolderVar to empty.
At first glance it looks like join_is_removable ensures that's true --- but
actually, the loop in join_is_removable skips PlaceHolderVars that are not
referenced above the join due to be removed. So, if we don't want any
empty eval_at sets, the right thing to do is to delete any now-unreferenced
PlaceHolderVars from the data structure entirely.
Per fuzz testing by Andreas Seltenreich. Back-patch to 9.3 where the
aforesaid Assert was added.
Diffstat (limited to 'contrib/btree_gist/btree_utils_num.h')
0 files changed, 0 insertions, 0 deletions