diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-12-10 18:26:43 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-12-10 18:26:43 -0500 |
| commit | d02ef65bce6575e10ac0b4e7b8552ff67687c944 (patch) | |
| tree | 3a993d5826fea7932e4d127ddd9168327b495a72 /contrib/hstore/hstore_gist.c | |
| parent | e730718072bdc8379f3d099c64455c20d6a6d1ad (diff) | |
Standardize error reports in unimplemented I/O functions.
We chose a specific wording of the not-implemented errors for
pseudotype I/O functions and other cases where there's little
value in implementing input and/or output. gtsvectorin never
got that memo though, nor did most of contrib. Make these all
fall in line, mostly because I'm a neatnik but also to remove
unnecessary translatable strings.
gbtreekey_in needs a bit of extra love since it supports
multiple SQL types. Sadly, gbtreekey_out doesn't have the
ability to do that, but I think it's unreachable anyway.
Noted while surveying datatype input functions to see what we
have left to fix.
Diffstat (limited to 'contrib/hstore/hstore_gist.c')
| -rw-r--r-- | contrib/hstore/hstore_gist.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/contrib/hstore/hstore_gist.c b/contrib/hstore/hstore_gist.c index 39ba92a6bf4..5d8b806d30a 100644 --- a/contrib/hstore/hstore_gist.c +++ b/contrib/hstore/hstore_gist.c @@ -96,15 +96,21 @@ PG_FUNCTION_INFO_V1(ghstore_out); Datum ghstore_in(PG_FUNCTION_ARGS) { - elog(ERROR, "Not implemented"); - PG_RETURN_DATUM(0); + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot accept a value of type %s", "ghstore"))); + + PG_RETURN_VOID(); /* keep compiler quiet */ } Datum ghstore_out(PG_FUNCTION_ARGS) { - elog(ERROR, "Not implemented"); - PG_RETURN_DATUM(0); + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("cannot display a value of type %s", "ghstore"))); + + PG_RETURN_VOID(); /* keep compiler quiet */ } static GISTTYPE * |