diff options
| author | Fujii Masao <fujii@postgresql.org> | 2020-07-03 11:35:22 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2020-07-03 11:35:22 +0900 |
| commit | d1763ea8c9c32837d373a196ed0c2e1256a55824 (patch) | |
| tree | d37d50b0563a0d1fc5f230240ea7e9f9b0cd8a36 /contrib/pg_stat_statements/pg_stat_statements.c | |
| parent | 947456a823d6b0973b68c6b38c8623a0504054e7 (diff) | |
Change default of pg_stat_statements.track_planning to off.
Since v13 pg_stat_statements is allowed to track the planning time of
statements when track_planning option is enabled. Its default was on.
But this feature could cause more terrible spinlock contentions in
pg_stat_statements. As a result of this, Robins Tharakan reported that
v13 beta1 showed ~45% performance drop at high DB connection counts
(when compared with v12.3) during fully-cached SELECT-only test using
pgbench.
To avoid this performance regression by the default setting,
this commit changes default of pg_stat_statements.track_planning to off.
Back-patch to v13 where pg_stat_statements.track_planning was introduced.
Reported-by: Robins Tharakan
Author: Fujii Masao
Reviewed-by: Julien Rouhaud
Discussion: https://postgr.es/m/2895b53b033c47ccb22972b589050dd9@EX13D05UWC001.ant.amazon.com
Diffstat (limited to 'contrib/pg_stat_statements/pg_stat_statements.c')
| -rw-r--r-- | contrib/pg_stat_statements/pg_stat_statements.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index cef8bb5a49a..65ac301b99f 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -442,7 +442,7 @@ _PG_init(void) "Selects whether planning duration is tracked by pg_stat_statements.", NULL, &pgss_track_planning, - true, + false, PGC_SUSET, 0, NULL, |