diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2013-03-15 17:41:47 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2013-03-15 17:41:47 -0400 |
| commit | 70ec2f8f4392f4e3d379c2c759789d631ffeec10 (patch) | |
| tree | 50bfd7dd704bf49e6e96cf0debeaadcd839b6049 /contrib/pg_test_fsync/pg_test_fsync.c | |
| parent | dcafdbcde1baf256891be6af77868b84889b435d (diff) | |
Improve the documentation about commit_delay.
Clarify the docs explaining what commit_delay does, and add a
recommendation about a useful value for it, namely half of the single-page
fsync time reported by pg_test_fsync. This is informed by testing of
the new-in-9.3 implementation of commit_delay; in prior versions it
was far harder to arrive at a useful setting.
In passing, do some wordsmithing and markup-fixing in the same general
area.
Also, change pg_test_fsync's default time-per-test from 2 seconds to 5.
The old value was about the minimum at which the results could be taken
seriously at all, and so seems a tad optimistic as a default.
Peter Geoghegan, reviewed by Noah Misch; some additional editing by me
Diffstat (limited to 'contrib/pg_test_fsync/pg_test_fsync.c')
| -rw-r--r-- | contrib/pg_test_fsync/pg_test_fsync.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/pg_test_fsync/pg_test_fsync.c b/contrib/pg_test_fsync/pg_test_fsync.c index ec4b90c7974..5ee03981a3b 100644 --- a/contrib/pg_test_fsync/pg_test_fsync.c +++ b/contrib/pg_test_fsync/pg_test_fsync.c @@ -60,7 +60,7 @@ do { \ static const char *progname; -static int secs_per_test = 2; +static int secs_per_test = 5; static int needs_unlink = 0; static char full_buf[XLOG_SEG_SIZE], *buf, |