diff options
| author | Amit Kapila <akapila@postgresql.org> | 2020-09-11 10:00:01 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2020-09-11 10:00:01 +0530 |
| commit | 0ba5181c00eb0216bdfd9afbf3d680fee67d34b3 (patch) | |
| tree | 250356edd17e6087427dc4551fe51c3c74368d36 /contrib/test_decoding/Makefile | |
| parent | 9f1cf97bb5387a6243c8a6c9725616ef7447962e (diff) | |
Skip empty transaction stream in test_decoding.
We were decoding empty transactions via streaming APIs added in commit
45fdc9738b even when the user used the option 'skip-empty-xacts'. The APIs
makes no effort to skip empty xacts under the assumption that we will
never try to stream such transactions. However, that is not true because
we can pick to stream a transaction that has change messages for
REORDER_BUFFER_CHANGE_INTERNAL_SNAPSHOT and we don't send such messages to
downstream rather they are just to update the internal state. So, we need
to skip such xacts when plugin uses the option 'skip-empty-xacts'.
Diagnosed-By: Amit Kapila
Author: Dilip Kumar
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CAA4eK1+OqgFNZkf7=ETe_y5ntjgDk3T0wcdkd4Sot_u1hySGfw@mail.gmail.com
Diffstat (limited to 'contrib/test_decoding/Makefile')
| -rw-r--r-- | contrib/test_decoding/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/test_decoding/Makefile b/contrib/test_decoding/Makefile index ed9a3d6c0ed..f23f15b04d4 100644 --- a/contrib/test_decoding/Makefile +++ b/contrib/test_decoding/Makefile @@ -7,7 +7,7 @@ REGRESS = ddl xact rewrite toast permissions decoding_in_xact \ decoding_into_rel binary prepared replorigin time messages \ spill slot truncate stream ISOLATION = mxact delayed_startup ondisk_startup concurrent_ddl_dml \ - oldest_xmin snapshot_transfer subxact_without_top + oldest_xmin snapshot_transfer subxact_without_top concurrent_stream REGRESS_OPTS = --temp-config $(top_srcdir)/contrib/test_decoding/logical.conf ISOLATION_OPTS = --temp-config $(top_srcdir)/contrib/test_decoding/logical.conf |