diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-03-01 05:16:40 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-03-01 05:16:40 +0000 |
| commit | 5ea32f560a411e806b0665a5e091d85d1565ee2e (patch) | |
| tree | da87e0bfec5e0628006cb32513351afbdeb92fd5 /contrib/xml2/xslt_proc.c | |
| parent | 8748dc35800d7a4f46cf469ede12583b5fb52a9e (diff) | |
Remove xmlCleanupParser calls from contrib/xml2.
These are unnecessary and probably dangerous. I don't see any immediate
risk situations in the core XML support or contrib/xml2 itself, but there
could be issues with external uses of libxml2, and in any case it's an
accident waiting to happen.
Diffstat (limited to 'contrib/xml2/xslt_proc.c')
| -rw-r--r-- | contrib/xml2/xslt_proc.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/contrib/xml2/xslt_proc.c b/contrib/xml2/xslt_proc.c index 98a6257a3d6..ef912925820 100644 --- a/contrib/xml2/xslt_proc.c +++ b/contrib/xml2/xslt_proc.c @@ -1,5 +1,5 @@ /* - * $PostgreSQL: pgsql/contrib/xml2/xslt_proc.c,v 1.15.2.2 2010/03/01 03:41:04 tgl Exp $ + * $PostgreSQL: pgsql/contrib/xml2/xslt_proc.c,v 1.15.2.3 2010/03/01 05:16:40 tgl Exp $ * * XSLT processing functions (requiring libxslt) * @@ -79,7 +79,6 @@ xslt_process(PG_FUNCTION_ARGS) if (doctree == NULL) { - xmlCleanupParser(); elog_error("error parsing XML document", false); PG_RETURN_NULL(); @@ -93,7 +92,6 @@ xslt_process(PG_FUNCTION_ARGS) if (ssdoc == NULL) { xmlFreeDoc(doctree); - xmlCleanupParser(); elog_error("error parsing stylesheet as XML document", false); PG_RETURN_NULL(); } @@ -108,7 +106,6 @@ xslt_process(PG_FUNCTION_ARGS) { xmlFreeDoc(doctree); xsltCleanupGlobals(); - xmlCleanupParser(); elog_error("failed to parse stylesheet", false); PG_RETURN_NULL(); } @@ -121,7 +118,6 @@ xslt_process(PG_FUNCTION_ARGS) xmlFreeDoc(doctree); xsltCleanupGlobals(); - xmlCleanupParser(); if (resstat < 0) PG_RETURN_NULL(); |