Code review for pg_stat_get_backend_activity_start patch --- fix

return type, make protection condition agree with recent change to
pg_stat_get_backend_activity, clean up documentation.

2 files changed, 14 insertions, 13 deletions

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 231a099cd1a..90a77d0a2c8 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1,5 +1,5 @@
 <!--
-$Header: /cvsroot/pgsql/doc/src/sgml/monitoring.sgml,v 1.19 2003/03/25 16:15:37 petere Exp $
+$Header: /cvsroot/pgsql/doc/src/sgml/monitoring.sgml,v 1.20 2003/04/04 03:03:53 tgl Exp $
 -->
 
 <chapter id="monitoring">
@@ -208,9 +208,9 @@ postgres: <replaceable>user</> <replaceable>database</> <replaceable>host</> <re
       which the current query began execution. The columns that report
       data on the current query are only available if the parameter
       <varname>stats_command_string</varname> has been turned on.
-      Furthermore, these columns can only be accessed by
-      superusers; or when the user examining the view is the same as the user
-      in the row; for others it reads as null.  (Note that because of the 
+      Furthermore, these columns read as null unless the user examining
+      the view is a superuser or the same as the user owning the process
+      being reported on.  (Note that because of the 
       collector's reporting delay, current query will only be up-to-date for 
       long-running queries.)</entry>
      </row>
@@ -540,16 +540,16 @@ postgres: <replaceable>user</> <replaceable>database</> <replaceable>host</> <re
 
      <row>
       <entry><literal><function>pg_stat_get_backend_activity_start</function>(<type>integer</type>)</literal></entry>
-      <entry><type>text</type></entry>
+      <entry><type>timestamp with time zone</type></entry>
       <entry>
-       The time at which the specified backend process' currently
-       executing query was started (null if the current user is not a
-       superuser, or <varname>stats_command_string</varname> is not
-       on)
+       The time at which the given backend process' currently
+       executing query was started (null if the
+       current user is not a superuser nor the same user as that of
+       the session being queried, or
+       <varname>stats_command_string</varname> is not on)
       </entry>
      </row>
 
-
      <row>
       <entry><literal><function>pg_stat_reset</function>()</literal></entry>
       <entry><type>boolean</type></entry>
diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml
index 131a670b59a..9311aabfda3 100644
--- a/doc/src/sgml/runtime.sgml
+++ b/doc/src/sgml/runtime.sgml
@@ -1,5 +1,5 @@
 <!--
-$Header: /cvsroot/pgsql/doc/src/sgml/runtime.sgml,v 1.176 2003/04/03 23:32:47 tgl Exp $
+$Header: /cvsroot/pgsql/doc/src/sgml/runtime.sgml,v 1.177 2003/04/04 03:03:53 tgl Exp $
 -->
 
 <Chapter Id="runtime">
@@ -1176,8 +1176,9 @@ SET ENABLE_SEQSCAN TO OFF;
         Enables the collection of statistics on the currently
         executing command of each session, along with the time at
         which that command began execution. This option is off by
-        default. Note that even when enabled, this information is only
-        visible to the superuser, so it should not represent a
+        default. Note that even when enabled, this information is not
+	visible to all users, only to superusers and the user owning
+	the session being reported on; so it should not represent a
         security risk. This data can be accessed via the
         <structname>pg_stat_activity</structname> system view; refer
         to <xref linkend="monitoring"> for more information.