diff options
| author | Andres Freund <andres@anarazel.de> | 2018-07-22 14:58:01 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2018-07-22 14:58:23 -0700 |
| commit | 86eaf208ea048936df6be77276a246d3f92e9620 (patch) | |
| tree | d0b7d529bba5f072457c003c951d05ca2aa90caa /doc/src | |
| parent | 3522d0eaba5a976f09a48810dd25dff6ab3565df (diff) | |
Hand code string to integer conversion for performance.
As benchmarks show, using libc's string-to-integer conversion is
pretty slow. At least part of the reason for that is that strtol[l]
have to be more generic than what largely is required inside pg.
This patch considerably speeds up int2/int4 input (int8 already was
already using hand-rolled code).
Most of the existing pg_atoi callers have been converted. But as one
requires pg_atoi's custom delimiter functionality, and as it seems
likely that there's external pg_atoi users, it seems sensible to just
keep pg_atoi around.
Author: Andres Freund
Reviewed-By: Robert Haas
Discussion: https://postgr.es/m/20171208214437.qgn6zdltyq5hmjpk@alap3.anarazel.de
Diffstat (limited to 'doc/src')
| -rw-r--r-- | doc/src/sgml/sources.sgml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgml index 8870ee938aa..b08919dc70f 100644 --- a/doc/src/sgml/sources.sgml +++ b/doc/src/sgml/sources.sgml @@ -709,7 +709,7 @@ BETTER: could not open file %s (I/O failure) not helpful information. If the error text doesn't make as much sense without the function name, reword it. <programlisting> -BAD: pg_atoi: error in "z": cannot parse "z" +BAD: pg_strtoint32: error in "z": cannot parse "z" BETTER: invalid input syntax for integer: "z" </programlisting> </para> |