diff options
| author | Teodor Sigaev <teodor@sigaev.ru> | 2007-06-05 12:48:21 +0000 |
|---|---|---|
| committer | Teodor Sigaev <teodor@sigaev.ru> | 2007-06-05 12:48:21 +0000 |
| commit | 5e87f49a4cfebb4d5d4b040d37ab98a0837a2284 (patch) | |
| tree | 9b294ac60dd67575606b1b11cd35232f5271903f /src/backend/access/gin/ginbtree.c | |
| parent | 07bd1db152e95a44722c1fd23572dfeaf8e07eaf (diff) | |
Move call of MarkBufferDirty() before XLogInsert() as required.
Many thanks to Heikki Linnakangas <heikki@enterprisedb.com> for his
sharp eyes.
Diffstat (limited to 'src/backend/access/gin/ginbtree.c')
| -rw-r--r-- | src/backend/access/gin/ginbtree.c | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/src/backend/access/gin/ginbtree.c b/src/backend/access/gin/ginbtree.c index aee72990bce..f0490581c5c 100644 --- a/src/backend/access/gin/ginbtree.c +++ b/src/backend/access/gin/ginbtree.c @@ -8,7 +8,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/gin/ginbtree.c,v 1.6 2006/11/12 06:55:53 neilc Exp $ + * $PostgreSQL: pgsql/src/backend/access/gin/ginbtree.c,v 1.6.2.1 2007/06/05 12:48:21 teodor Exp $ *------------------------------------------------------------------------- */ @@ -294,6 +294,8 @@ ginInsertValue(GinBtree btree, GinBtreeStack *stack) START_CRIT_SECTION(); btree->placeToPage(btree, stack->buffer, stack->off, &rdata); + MarkBufferDirty(stack->buffer); + if (!btree->index->rd_istemp) { XLogRecPtr recptr; @@ -303,7 +305,6 @@ ginInsertValue(GinBtree btree, GinBtreeStack *stack) PageSetTLI(page, ThisTimeLineID); } - MarkBufferDirty(stack->buffer); UnlockReleaseBuffer(stack->buffer); END_CRIT_SECTION(); @@ -351,6 +352,11 @@ ginInsertValue(GinBtree btree, GinBtreeStack *stack) GinInitBuffer(stack->buffer, GinPageGetOpaque(newlpage)->flags & ~GIN_LEAF); PageRestoreTempPage(newlpage, lpage); btree->fillRoot(btree, stack->buffer, lbuffer, rbuffer); + + MarkBufferDirty(rbuffer); + MarkBufferDirty(lbuffer); + MarkBufferDirty(stack->buffer); + if (!btree->index->rd_istemp) { XLogRecPtr recptr; @@ -364,11 +370,8 @@ ginInsertValue(GinBtree btree, GinBtreeStack *stack) PageSetTLI(rpage, ThisTimeLineID); } - MarkBufferDirty(rbuffer); UnlockReleaseBuffer(rbuffer); - MarkBufferDirty(lbuffer); UnlockReleaseBuffer(lbuffer); - MarkBufferDirty(stack->buffer); UnlockReleaseBuffer(stack->buffer); END_CRIT_SECTION(); @@ -389,6 +392,10 @@ ginInsertValue(GinBtree btree, GinBtreeStack *stack) START_CRIT_SECTION(); PageRestoreTempPage(newlpage, lpage); + + MarkBufferDirty(rbuffer); + MarkBufferDirty(stack->buffer); + if (!btree->index->rd_istemp) { XLogRecPtr recptr; @@ -399,9 +406,7 @@ ginInsertValue(GinBtree btree, GinBtreeStack *stack) PageSetLSN(rpage, recptr); PageSetTLI(rpage, ThisTimeLineID); } - MarkBufferDirty(rbuffer); UnlockReleaseBuffer(rbuffer); - MarkBufferDirty(stack->buffer); END_CRIT_SECTION(); } } |