diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-09-07 20:59:26 +0000 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-09-07 20:59:26 +0000 |
commit | 0a51e7073c045b5fce50092dae19f398f7b38e16 (patch) | |
tree | 8f33ac25cc0653195f86b76f724b52360f3fbc80 /src/backend/access/heap/heapam.c | |
parent | 85e79a4a83d6f6fb505474a720eb32fd88067c16 (diff) |
Don't take ProcArrayLock while exiting a transaction that has no XID; there is
no need for serialization against snapshot-taking because the xact doesn't
affect anyone else's snapshot anyway. Per discussion. Also, move various
info about the interlocking of transactions and snapshots out of code comments
and into a hopefully-more-cohesive discussion in access/transam/README.
Also, remove a couple of now-obsolete comments about having to force some WAL
to be written to persuade RecordTransactionCommit to do its thing.
Diffstat (limited to 'src/backend/access/heap/heapam.c')
-rw-r--r-- | src/backend/access/heap/heapam.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index 3f23378b8fa..f1ca5249cae 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.238 2007/09/05 18:10:47 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/access/heap/heapam.c,v 1.239 2007/09/07 20:59:26 tgl Exp $ * * * INTERFACE ROUTINES @@ -1546,9 +1546,8 @@ UpdateXmaxHintBits(HeapTupleHeader tuple, Buffer buffer, TransactionId xid) * If use_wal is false, the new tuple is not logged in WAL, even for a * non-temp relation. Safe usage of this behavior requires that we arrange * that all new tuples go into new pages not containing any tuples from other - * transactions, that the relation gets fsync'd before commit, and that the - * transaction emits at least one WAL record to ensure RecordTransactionCommit - * will decide to WAL-log the commit. (See also heap_sync() comments) + * transactions, and that the relation gets fsync'd before commit. + * (See also heap_sync() comments) * * use_fsm is passed directly to RelationGetBufferForTuple, which see for * more info. |