diff options
| author | Andres Freund <andres@anarazel.de> | 2015-01-03 20:51:52 +0100 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2015-01-03 20:54:13 +0100 |
| commit | 90e4a2bf9b131f45fd4d80815b2b3505bb98c0a6 (patch) | |
| tree | 632780c7201afcc233f9e2fb9603b697c4c4fa94 /src/backend/access/heap/heapam.c | |
| parent | 70e36adb0d4b7f4656a06a5396a4cf65fc863323 (diff) | |
Prevent WAL files created by pg_basebackup -x/X from being archived again.
WAL (and timeline history) files created by pg_basebackup did not
maintain the new base backup's archive status. That's currently not a
problem if the new node is used as a standby - but if that node is
promoted all still existing files can get archived again. With a high
wal_keep_segment settings that can happen a significant time later -
which is quite confusing.
Change both the backend (for the -x/-X fetch case) and pg_basebackup
(for -X stream) itself to always mark WAL/timeline files included in
the base backup as .done. That's in line with walreceiver.c doing so.
The verbosity of the pg_basebackup changes show pretty clearly that it
needs some refactoring, but that'd result in not be backpatchable
changes.
Backpatch to 9.1 where pg_basebackup was introduced.
Discussion: 20141205002854.GE21964@awork2.anarazel.de
Diffstat (limited to 'src/backend/access/heap/heapam.c')
0 files changed, 0 insertions, 0 deletions