diff options
| author | Peter Geoghegan <pg@bowt.ie> | 2019-05-13 15:53:39 -0700 |
|---|---|---|
| committer | Peter Geoghegan <pg@bowt.ie> | 2019-05-13 15:53:39 -0700 |
| commit | ae7291acbc5ae4c3751615177fc256f9f3399403 (patch) | |
| tree | 8a67a1936fe81aa9d5e5b1c4b023f7993d6b9437 /src/backend/access/heap/pruneheap.c | |
| parent | 08ca9d7feca890e97f77ef1fde02d7542a54ac5e (diff) | |
Standardize ItemIdData terminology.
The term "item pointer" should not be used to refer to ItemIdData
variables, since that is needlessly ambiguous. Only
ItemPointerData/ItemPointer variables should be called item pointers.
To fix, establish the convention that ItemIdData variables should always
be referred to either as "item identifiers" or "line pointers". The
term "item identifier" already predominates in docs and translatable
messages, and so should be the preferred alternative there.
Discussion: https://postgr.es/m/CAH2-Wz=c=MZQjUzde3o9+2PLAPuHTpVZPPdYxN=E4ndQ2--8ew@mail.gmail.com
Diffstat (limited to 'src/backend/access/heap/pruneheap.c')
| -rw-r--r-- | src/backend/access/heap/pruneheap.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c index a3e51922d85..417a2bf8e6e 100644 --- a/src/backend/access/heap/pruneheap.c +++ b/src/backend/access/heap/pruneheap.c @@ -324,7 +324,7 @@ heap_page_prune(Relation relation, Buffer buffer, TransactionId OldestXmin, /* - * Prune specified item pointer or a HOT chain originating at that item. + * Prune specified line pointer or a HOT chain originating at line pointer. * * If the item is an index-referenced tuple (i.e. not a heap-only tuple), * the HOT chain is pruned by removing all DEAD tuples at the start of the HOT @@ -454,7 +454,7 @@ heap_prune_chain(Relation relation, Buffer buffer, OffsetNumber rootoffnum, } /* - * Likewise, a dead item pointer can't be part of the chain. (We + * Likewise, a dead line pointer can't be part of the chain. (We * already eliminated the case of dead root tuple outside this * function.) */ @@ -630,7 +630,7 @@ heap_prune_record_prunable(PruneState *prstate, TransactionId xid) prstate->new_prune_xid = xid; } -/* Record item pointer to be redirected */ +/* Record line pointer to be redirected */ static void heap_prune_record_redirect(PruneState *prstate, OffsetNumber offnum, OffsetNumber rdoffnum) @@ -645,7 +645,7 @@ heap_prune_record_redirect(PruneState *prstate, prstate->marked[rdoffnum] = true; } -/* Record item pointer to be marked dead */ +/* Record line pointer to be marked dead */ static void heap_prune_record_dead(PruneState *prstate, OffsetNumber offnum) { @@ -656,7 +656,7 @@ heap_prune_record_dead(PruneState *prstate, OffsetNumber offnum) prstate->marked[offnum] = true; } -/* Record item pointer to be marked unused */ +/* Record line pointer to be marked unused */ static void heap_prune_record_unused(PruneState *prstate, OffsetNumber offnum) { |