diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-20 17:28:07 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-01-20 17:28:07 -0500 |
| commit | 1145ad1ac5b7347071adb6186d9b56421b7ab40f (patch) | |
| tree | dca6b61bf47fc4d00e7826e34818c63c02b51dca /src/backend/access/heap/rewriteheap.c | |
| parent | a5bd14d93046cd3744558a14a8f6ed0042ae0998 (diff) | |
Tighten TAP tests' tracking of postmaster state some more.
Commits 6c4a8903b et al. had a couple of deficiencies:
* The logic I added to Cluster::start to see if a PID file is present
could be fooled by a stale PID file left over from a previous
postmaster. To fix, if we're not sure whether we expect to find a
running postmaster or not, validate the PID using "kill 0".
* 017_shm.pl has a loop in which it just issues repeated Cluster::start
calls; this will fail if some invocation fails but leaves self->_pid
set. Per buildfarm results, the above fix is not enough to make this
safe: we might have "validated" a PID for a postmaster that exits
immediately after we look. Hence, match each failed start call with
a stop call that will get us back to the self->_pid == undef state.
Add a fail_ok option to Cluster::stop to make this work.
Discussion: https://postgr.es/m/CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com
Diffstat (limited to 'src/backend/access/heap/rewriteheap.c')
0 files changed, 0 insertions, 0 deletions