diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2000-07-31 22:39:17 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2000-07-31 22:39:17 +0000 |
| commit | 7d0c4188f1b2c5e6b158dac3acab6def10959cae (patch) | |
| tree | 599c1c4d2231c2ad78cf3c9ec43472b78abff6a9 /src/backend/access/heap | |
| parent | b7319d371790c6103813ab1c6ac4646ba985c9d8 (diff) | |
Make acl-related functions safe for TOAST. Mark pg_class.relacl as
compressible but not externally storable (since we're not sure about
whether creating a toast relation for pg_class would work).
Diffstat (limited to 'src/backend/access/heap')
| -rw-r--r-- | src/backend/access/heap/tuptoaster.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c index 482bb924dcb..bab11857303 100644 --- a/src/backend/access/heap/tuptoaster.c +++ b/src/backend/access/heap/tuptoaster.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.9 2000/07/22 11:18:46 wieck Exp $ + * $Header: /cvsroot/pgsql/src/backend/access/heap/tuptoaster.c,v 1.10 2000/07/31 22:39:17 tgl Exp $ * * * INTERFACE ROUTINES @@ -273,7 +273,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup) /* ---------- * If the old value is an external stored one, check if it - * has changed so we have to detele it later. + * has changed so we have to delete it later. * ---------- */ if (!old_isnull && att[i]->attlen == -1 && @@ -336,17 +336,16 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup) if (att[i]->attlen == -1) { /* ---------- - * If the tables attribute say's PLAIN allways, we - * do so below. + * If the table's attribute says PLAIN always, force it so. * ---------- */ if (att[i]->attstorage == 'p') toast_action[i] = 'p'; /* ---------- - * We're running for UPDATE, so any TOASTed value we find - * still in the tuple must be someone elses we cannot reuse. - * Expand it to plain and eventually toast it again below. + * We took care of UPDATE above, so any TOASTed value we find + * still in the tuple must be someone else's we cannot reuse. + * Expand it to plain (and, probably, toast it again below). * ---------- */ if (VARATT_IS_EXTENDED(DatumGetPointer(toast_values[i]))) @@ -367,7 +366,7 @@ toast_insert_or_update(Relation rel, HeapTuple newtup, HeapTuple oldtup) else { /* ---------- - * Not a variable size attribute, plain storage allways + * Not a variable size attribute, plain storage always * ---------- */ toast_action[i] = 'p'; |