summaryrefslogtreecommitdiff
path: root/src/backend/access/nbtree/nbtxlog.c
diff options
context:
space:
mode:
authorSimon Riggs <simon@2ndQuadrant.com>2014-05-06 14:45:05 +0100
committerSimon Riggs <simon@2ndQuadrant.com>2014-05-06 14:45:05 +0100
commit41fdcf71d2b424104e08ce229104b8e8e2840d1b (patch)
treea61607c540c433d45563409093061c3f293cd074 /src/backend/access/nbtree/nbtxlog.c
parenta7a3e71c8592a530f9a605aea4f08af7ad8e0ab3 (diff)
Correct comment in Hot Standby nbtree handling
Logic is correct, matching handling of LP_DEAD elsewhere.
Diffstat (limited to 'src/backend/access/nbtree/nbtxlog.c')
-rw-r--r--src/backend/access/nbtree/nbtxlog.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
index af1b5ab07af..8e2b0b6459a 100644
--- a/src/backend/access/nbtree/nbtxlog.c
+++ b/src/backend/access/nbtree/nbtxlog.c
@@ -719,11 +719,11 @@ btree_xlog_delete_get_latestRemovedXid(xl_btree_delete *xlrec)
UnlockReleaseBuffer(ibuffer);
/*
- * XXX If all heap tuples were LP_DEAD then we will be returning
- * InvalidTransactionId here, causing conflict for all HS transactions.
- * That should happen very rarely (reasoning please?). Also note that
- * caller can't tell the difference between this case and the fast path
- * exit above. May need to change that in future.
+ * If all heap tuples were LP_DEAD then we will be returning
+ * InvalidTransactionId here, which avoids conflicts. This matches
+ * existing logic which assumes that LP_DEAD tuples must already be
+ * older than the latestRemovedXid on the cleanup record that
+ * set them as LP_DEAD, hence must already have generated a conflict.
*/
return latestRemovedXid;
}