diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2001-01-12 21:54:01 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2001-01-12 21:54:01 +0000 |
| commit | 6162432de9fb023b710c171f196e27b910e45fa7 (patch) | |
| tree | 51bba2e60ca2d3497b365b23edd52d52574faae2 /src/backend/access/transam/xact.c | |
| parent | be8477bc3718a05b02dd7e9f8236c16394f9a027 (diff) | |
Add more critical-section calls: all code sections that hold spinlocks
are now critical sections, so as to ensure die() won't interrupt us while
we are munging shared-memory data structures. Avoid insecure intermediate
states in some code that proc_exit will call, like palloc/pfree. Rename
START/END_CRIT_CODE to START/END_CRIT_SECTION, since that seems to be
what people tend to call them anyway, and make them be called with () like
a function call, in hopes of not confusing pg_indent.
I doubt that this is sufficient to make SIGTERM safe anywhere; there's
just too much code that could get invoked during proc_exit().
Diffstat (limited to 'src/backend/access/transam/xact.c')
| -rw-r--r-- | src/backend/access/transam/xact.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 50f4f1a1009..e3f4a5618f7 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.91 2000/12/28 13:00:08 vadim Exp $ + * $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.92 2001/01/12 21:53:56 tgl Exp $ * * NOTES * Transaction aborts can now occur two ways: @@ -678,7 +678,7 @@ RecordTransactionCommit() rdata.len = SizeOfXactCommit; rdata.next = NULL; - START_CRIT_CODE; + START_CRIT_SECTION(); /* * SHOULD SAVE ARRAY OF RELFILENODE-s TO DROP */ @@ -697,7 +697,7 @@ RecordTransactionCommit() TransactionIdCommit(xid); MyProc->logRec.xrecoff = 0; - END_CRIT_CODE; + END_CRIT_SECTION(); } if (leak) @@ -800,12 +800,12 @@ RecordTransactionAbort(void) rdata.len = SizeOfXactAbort; rdata.next = NULL; - START_CRIT_CODE; + START_CRIT_SECTION(); recptr = XLogInsert(RM_XACT_ID, XLOG_XACT_ABORT, &rdata); TransactionIdAbort(xid); MyProc->logRec.xrecoff = 0; - END_CRIT_CODE; + END_CRIT_SECTION(); } /* |