diff options
author | Thomas Munro <tmunro@postgresql.org> | 2024-02-12 10:47:57 +1300 |
---|---|---|
committer | Thomas Munro <tmunro@postgresql.org> | 2024-02-12 11:14:21 +1300 |
commit | 65f438471b769f6b9706a386028f81df065d0a25 (patch) | |
tree | 64116ef6f549bc3bef6d7b98a5a14ea52a5b4903 /src/backend/access/transam/xlogreader.c | |
parent | e70abd67c3e6155fe8e853c4e29255578d9cf48d (diff) |
Fix gai_strerror() thread-safety on Windows.
Commit 5579388d removed code that supplied a fallback implementation of
getaddrinfo(), which was dead code on modern systems. One tiny piece of
the removed code was still doing something useful on Windows, though:
that OS's own gai_strerror()/gai_strerrorA() function returns a pointer
to a static buffer that it overwrites each time, so it's not
thread-safe. In rare circumstances, a multi-threaded client program
could get an incorrect or corrupted error message.
Restore the replacement gai_strerror() function, though now that it's
only for Windows we can put it into a win32-specific file and cut it
down to the errors that Windows documents. The error messages here are
taken from FreeBSD, because Windows' own messages seemed too verbose.
Back-patch to 16.
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/CA%2BhUKGKz%2BF9d2PTiXwfYV7qJw%2BWg2jzACgSDgPizUw7UG%3Di58A%40mail.gmail.com
Diffstat (limited to 'src/backend/access/transam/xlogreader.c')
0 files changed, 0 insertions, 0 deletions