diff options
| author | Robert Haas <rhaas@postgresql.org> | 2012-09-14 09:35:07 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2012-09-14 09:36:46 -0400 |
| commit | eb6e9b5ea4a5e733da705c053906f3aff47c9bf5 (patch) | |
| tree | 9050c9bafc66cee43d8f444c848005df7d3da6b9 /src/backend/access/transam/xlogutils.c | |
| parent | 269dbaf7076c96b3301abb7571fde42e183bf363 (diff) | |
Properly set relpersistence for fake relcache entries.
This can result in buffers failing to be properly flushed at
checkpoint time, leading to data loss.
Report, diagnosis, and patch by Jeff Davis.
Diffstat (limited to 'src/backend/access/transam/xlogutils.c')
| -rw-r--r-- | src/backend/access/transam/xlogutils.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/backend/access/transam/xlogutils.c b/src/backend/access/transam/xlogutils.c index 6ddcc59b37a..5676120a863 100644 --- a/src/backend/access/transam/xlogutils.c +++ b/src/backend/access/transam/xlogutils.c @@ -394,6 +394,8 @@ CreateFakeRelcacheEntry(RelFileNode rnode) FakeRelCacheEntry fakeentry; Relation rel; + Assert(InRecovery); + /* Allocate the Relation struct and all related space in one block. */ fakeentry = palloc0(sizeof(FakeRelCacheEntryData)); rel = (Relation) fakeentry; @@ -403,6 +405,9 @@ CreateFakeRelcacheEntry(RelFileNode rnode) /* We will never be working with temp rels during recovery */ rel->rd_backend = InvalidBackendId; + /* It must be a permanent table if we're in recovery. */ + rel->rd_rel->relpersistence = RELPERSISTENCE_PERMANENT; + /* We don't know the name of the relation; use relfilenode instead */ sprintf(RelationGetRelationName(rel), "%u", rnode.relNode); |