diff options
| author | Andres Freund <andres@anarazel.de> | 2019-06-10 23:20:48 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2019-06-10 23:36:48 -0700 |
| commit | 52ad5fc0a6c353a72513cc3730d062a2de1d4952 (patch) | |
| tree | 4c8b54814edef6910522c50de643c705f22a7f2e /src/backend/commands/constraint.c | |
| parent | 1eb8a5ea463dcbe6546f684e862649fd4e643953 (diff) | |
Don't access catalogs to validate GUCs when not connected to a DB.
Vignesh found this bug in the check function for
default_table_access_method's check hook, but that was just copied
from older GUCs. Investigation by Michael and me then found the bug in
further places.
When not connected to a database (e.g. in a walsender connection), we
cannot perform (most) GUC checks that need database access. Even when
only shared tables are needed, unless they're
nailed (c.f. RelationCacheInitializePhase2()), they cannot be accessed
without pg_class etc. being present.
Fix by extending the existing IsTransactionState() checks to also
check for MyDatabaseOid.
Reported-By: Vignesh C, Michael Paquier, Andres Freund
Author: Vignesh C, Andres Freund
Discussion: https://postgr.es/m/CALDaNm1KXK9gbZfY-p_peRFm_XrBh1OwQO1Kk6Gig0c0fVZ2uw%40mail.gmail.com
Backpatch: 9.4-
Diffstat (limited to 'src/backend/commands/constraint.c')
0 files changed, 0 insertions, 0 deletions