summaryrefslogtreecommitdiff
path: root/src/backend/commands/conversioncmds.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2007-02-08 18:38:28 +0000
committerTom Lane <tgl@sss.pgh.pa.us>2007-02-08 18:38:28 +0000
commit6eb61d578f3c9fc4fff78d69851b7558821668e3 (patch)
treefda2c0c682857472485ca08dd4a61f3472df46d8 /src/backend/commands/conversioncmds.c
parentaf8a4243245abea0b8ed6ddb9e008d287019ad37 (diff)
Rearrange use of plpgsql_add_initdatums() so that only the parsing of a
DECLARE section needs to know about it. Formerly, everyplace besides DECLARE that created variables needed to do "plpgsql_add_initdatums(NULL)" to prevent those variables from being sucked up as part of a subsequent DECLARE block. This is obviously error-prone, and in fact the SQLSTATE/SQLERRM patch had failed to do it for those two variables, leading to the bug recently exhibited by Asif Ali Rehman: a DECLARE within an exception handler tried to reinitialize SQLERRM. Although the SQLSTATE/SQLERRM patch isn't in any pre-8.1 branches, and so I can't point to a demonstrable failure there, it seems wise to back-patch this into the older branches anyway, just to keep the logic similar to HEAD.
Diffstat (limited to 'src/backend/commands/conversioncmds.c')
0 files changed, 0 insertions, 0 deletions