diff options
author | Andres Freund <andres@anarazel.de> | 2020-02-06 19:06:16 -0800 |
---|---|---|
committer | Andres Freund <andres@anarazel.de> | 2020-02-06 19:54:43 -0800 |
commit | 1fdb7f9789c4550204cd62d1746a7deed1dc4c29 (patch) | |
tree | 877c68ff731bf42a811be492dca9c79db71494be /src/backend/executor/execExpr.c | |
parent | 1ec7679f1b67e84be688a311dce234eeaa1d5de8 (diff) |
expression eval: Don't redundantly keep track of AggState.
It's already tracked via ExprState->parent, so we don't need to also
include it in ExprEvalStep. When that code originally was written
ExprState->parent didn't exist, but it since has been introduced in
6719b238e8f.
Author: Andres Freund
Discussion: https://postgr.es/m/20191023163849.sosqbfs5yenocez3@alap3.anarazel.de
Diffstat (limited to 'src/backend/executor/execExpr.c')
-rw-r--r-- | src/backend/executor/execExpr.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/backend/executor/execExpr.c b/src/backend/executor/execExpr.c index af97f810067..121eff97a0c 100644 --- a/src/backend/executor/execExpr.c +++ b/src/backend/executor/execExpr.c @@ -810,7 +810,6 @@ ExecInitExprRec(Expr *node, ExprState *state, elog(ERROR, "GroupingFunc found in non-Agg plan node"); scratch.opcode = EEOP_GROUPING_FUNC; - scratch.d.grouping_func.parent = (AggState *) state->parent; agg = (Agg *) (state->parent->plan); @@ -3050,7 +3049,6 @@ ExecBuildAggTrans(AggState *aggstate, AggStatePerPhase phase, else scratch.opcode = EEOP_AGG_DESERIALIZE; - scratch.d.agg_deserialize.aggstate = aggstate; scratch.d.agg_deserialize.fcinfo_data = ds_fcinfo; scratch.d.agg_deserialize.jumpnull = -1; /* adjust later */ scratch.resvalue = &trans_fcinfo->args[argno + 1].value; @@ -3252,7 +3250,6 @@ ExecBuildAggTransCall(ExprState *state, AggState *aggstate, pertrans->initValueIsNull) { scratch->opcode = EEOP_AGG_INIT_TRANS; - scratch->d.agg_init_trans.aggstate = aggstate; scratch->d.agg_init_trans.pertrans = pertrans; scratch->d.agg_init_trans.setno = setno; scratch->d.agg_init_trans.setoff = setoff; @@ -3269,7 +3266,6 @@ ExecBuildAggTransCall(ExprState *state, AggState *aggstate, fcinfo->flinfo->fn_strict) { scratch->opcode = EEOP_AGG_STRICT_TRANS_CHECK; - scratch->d.agg_strict_trans_check.aggstate = aggstate; scratch->d.agg_strict_trans_check.setno = setno; scratch->d.agg_strict_trans_check.setoff = setoff; scratch->d.agg_strict_trans_check.transno = transno; @@ -3294,7 +3290,6 @@ ExecBuildAggTransCall(ExprState *state, AggState *aggstate, else scratch->opcode = EEOP_AGG_ORDERED_TRANS_TUPLE; - scratch->d.agg_trans.aggstate = aggstate; scratch->d.agg_trans.pertrans = pertrans; scratch->d.agg_trans.setno = setno; scratch->d.agg_trans.setoff = setoff; |