diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-11-30 14:51:27 +0100 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-11-30 15:07:47 +0100 |
| commit | f71b22f537b987f6f4b04f889bbd955c548d7d72 (patch) | |
| tree | 2e0ebe3203cc9d9616e0a8c57309b6e145c770fd /src/backend/executor/execIndexing.c | |
| parent | e429b03cc63b5879b87be6dd96c49c7868febeb1 (diff) | |
Fix off-by-one error in PGTYPEStimestamp_fmt_asc
When using %b or %B patterns to format a date, the code was simply using
tm_mon as an index into array of month names. But that is wrong, because
tm_mon is 1-based, while array indexes are 0-based. The result is we
either use name of the next month, or a segfault (for December).
Fix by subtracting 1 from tm_mon for both patterns, and add a regression
test triggering the issue. Backpatch to all supported versions (the bug
is there far longer, since at least 2003).
Reported-by: Paul Spencer
Backpatch-through: 9.4
Discussion: https://postgr.es/m/16143-0d861eb8688d3fef%40postgresql.org
Diffstat (limited to 'src/backend/executor/execIndexing.c')
0 files changed, 0 insertions, 0 deletions