diff options
| author | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-11-30 14:51:27 +0100 |
|---|---|---|
| committer | Tomas Vondra <tomas.vondra@postgresql.org> | 2019-11-30 15:10:14 +0100 |
| commit | c59414da7bd3be9f80e7585fc173d21942468d3b (patch) | |
| tree | e600c3126fab3200e5a78b80a97fdda842c3e6b4 /src/backend/executor/nodeMaterial.c | |
| parent | 474cd0931b758f4ee353fbc8cfc38a762b997be1 (diff) | |
Fix off-by-one error in PGTYPEStimestamp_fmt_asc
When using %b or %B patterns to format a date, the code was simply using
tm_mon as an index into array of month names. But that is wrong, because
tm_mon is 1-based, while array indexes are 0-based. The result is we
either use name of the next month, or a segfault (for December).
Fix by subtracting 1 from tm_mon for both patterns, and add a regression
test triggering the issue. Backpatch to all supported versions (the bug
is there far longer, since at least 2003).
Reported-by: Paul Spencer
Backpatch-through: 9.4
Discussion: https://postgr.es/m/16143-0d861eb8688d3fef%40postgresql.org
Diffstat (limited to 'src/backend/executor/nodeMaterial.c')
0 files changed, 0 insertions, 0 deletions