diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-10-01 11:39:14 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-10-01 11:39:14 -0400 |
| commit | 26318c4b858a1ba59ffa1d6b186c6302a9153c60 (patch) | |
| tree | a076200f6c635c49a052f325e86ed96a1f67fda1 /src/backend/executor/nodeTidscan.c | |
| parent | e5baf8c27e6cc2c83cc81b620e75ad3d571d51c4 (diff) | |
Fix ALTER COLUMN TYPE to not open a relation without any lock.
If the column being modified is referenced by a foreign key constraint
of another table, ALTER TABLE would open the other table (to re-parse
the constraint's definition) without having first obtained a lock on it.
This was evidently intentional, but that doesn't mean it's really safe.
It's especially not safe in 9.3, which pre-dates use of MVCC scans for
catalog reads, but even in current releases it doesn't seem like a good
idea.
We know we'll need AccessExclusiveLock shortly to drop the obsoleted
constraint, so just get that a little sooner to close the hole.
Per testing with a patch that complains if we open a relation without
holding any lock on it. I don't plan to back-patch that patch, but we
should close the holes it identifies in all supported branches.
Discussion: https://postgr.es/m/2038.1538335244@sss.pgh.pa.us
Diffstat (limited to 'src/backend/executor/nodeTidscan.c')
0 files changed, 0 insertions, 0 deletions