diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2006-12-26 19:27:26 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2006-12-26 19:27:26 +0000 |
| commit | d3db2bd80c8ee9a0cb2679ba341892e620a2676e (patch) | |
| tree | 4699a740828ca21566db9717a70c03068376da46 /src/backend/executor/nodeTidscan.c | |
| parent | 923ec1a19f5839dfb7628ad20521aa38f25b4e8f (diff) | |
Repair bug #2839: the various ExecReScan functions need to reset
ps_TupFromTlist in plan nodes that make use of it. This was being done
correctly in join nodes and Result nodes but not in any relation-scan nodes.
Bug would lead to bogus results if a set-returning function appeared in the
targetlist of a subquery that could be rescanned after partial execution,
for example a subquery within EXISTS(). Bug has been around forever :-(
... surprising it wasn't reported before.
Diffstat (limited to 'src/backend/executor/nodeTidscan.c')
| -rw-r--r-- | src/backend/executor/nodeTidscan.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/backend/executor/nodeTidscan.c b/src/backend/executor/nodeTidscan.c index f5e477663b5..18e81adac2f 100644 --- a/src/backend/executor/nodeTidscan.c +++ b/src/backend/executor/nodeTidscan.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/executor/nodeTidscan.c,v 1.26 2002/09/04 20:31:18 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/executor/nodeTidscan.c,v 1.26.2.1 2006/12/26 19:27:26 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -254,6 +254,8 @@ ExecTidReScan(TidScan *node, ExprContext *exprCtxt, Plan *parent) tidstate = node->tidstate; tidList = tidstate->tss_TidList; + node->scan.scanstate->cstate.cs_TupFromTlist = false; + /* If we are being passed an outer tuple, save it for runtime key calc */ if (exprCtxt != NULL) node->scan.scanstate->cstate.cs_ExprContext->ecxt_outertuple = @@ -411,6 +413,8 @@ ExecInitTidScan(TidScan *node, EState *estate, Plan *parent) */ ExecAssignExprContext(estate, &scanstate->cstate); + scanstate->cstate.cs_TupFromTlist = false; + #define TIDSCAN_NSLOTS 2 /* |