diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-01-26 12:25:44 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-01-26 12:25:44 -0500 |
| commit | 4971d2a32209118ebbdc6611341b89901e340902 (patch) | |
| tree | 8b59a637faaf915b2859db938e77bdabdbf3aa65 /src/backend/nodes/copyfuncs.c | |
| parent | b0313f9cc8f54d6a5c12f8987c9b6afa0a5bbced (diff) | |
Remove the obsolete WITH clause of CREATE FUNCTION.
This clause was superseded by SQL-standard syntax back in 7.3.
We've kept it around for backwards-compatibility purposes ever since;
but 15 years seems like long enough for that, especially seeing that
there are undocumented weirdnesses in how it interacts with the
SQL-standard syntax for specifying the same options.
Michael Paquier, per an observation by Daniel Gustafsson;
some small cosmetic adjustments to nearby code by me.
Discussion: https://postgr.es/m/20180115022748.GB1724@paquier.xyz
Diffstat (limited to 'src/backend/nodes/copyfuncs.c')
| -rw-r--r-- | src/backend/nodes/copyfuncs.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/backend/nodes/copyfuncs.c b/src/backend/nodes/copyfuncs.c index e5d2de53306..fd3001c4934 100644 --- a/src/backend/nodes/copyfuncs.c +++ b/src/backend/nodes/copyfuncs.c @@ -3217,7 +3217,7 @@ _copyClosePortalStmt(const ClosePortalStmt *from) static CallStmt * _copyCallStmt(const CallStmt *from) { - CallStmt *newnode = makeNode(CallStmt); + CallStmt *newnode = makeNode(CallStmt); COPY_NODE_FIELD(funccall); @@ -3422,13 +3422,12 @@ _copyCreateFunctionStmt(const CreateFunctionStmt *from) { CreateFunctionStmt *newnode = makeNode(CreateFunctionStmt); + COPY_SCALAR_FIELD(is_procedure); COPY_SCALAR_FIELD(replace); COPY_NODE_FIELD(funcname); COPY_NODE_FIELD(parameters); COPY_NODE_FIELD(returnType); - COPY_SCALAR_FIELD(is_procedure); COPY_NODE_FIELD(options); - COPY_NODE_FIELD(withClause); return newnode; } |