diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-12-10 11:12:43 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-12-10 11:12:43 -0500 |
| commit | 3af726a1f3bfccd0db3ea15c72e2df4943a17180 (patch) | |
| tree | 0a4a1320c9b69e2ec06527f3b6bc654a1abf25f8 /src/backend/nodes/outfuncs.c | |
| parent | 3a691f8a25a8c71c00918ee1694186de2d928c96 (diff) | |
Add stack depth checks to key recursive functions in backend/nodes/*.c.
Although copyfuncs.c has a check_stack_depth call in its recursion,
equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems
unwise.
Likewise fix planstate_tree_walker(), in branches where that exists.
Discussion: https://postgr.es/m/30253.1544286631@sss.pgh.pa.us
Diffstat (limited to 'src/backend/nodes/outfuncs.c')
| -rw-r--r-- | src/backend/nodes/outfuncs.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c index 9c16a1f4ea9..fd63db5c0d1 100644 --- a/src/backend/nodes/outfuncs.c +++ b/src/backend/nodes/outfuncs.c @@ -24,6 +24,7 @@ #include <ctype.h> #include "lib/stringinfo.h" +#include "miscadmin.h" #include "nodes/plannodes.h" #include "nodes/relation.h" #include "utils/datum.h" @@ -2757,6 +2758,9 @@ _outConstraint(StringInfo str, const Constraint *node) static void _outNode(StringInfo str, const void *obj) { + /* Guard against stack overflow due to overly complex expressions */ + check_stack_depth(); + if (obj == NULL) appendStringInfoString(str, "<>"); else if (IsA(obj, List) ||IsA(obj, IntList) || IsA(obj, OidList)) |