diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2006-12-24 00:29:20 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2006-12-24 00:29:20 +0000 |
| commit | c957c0bac7f9785ae2a7520a9f693eeda0ff545b (patch) | |
| tree | 36d172e97e59d00d39fe1b76401b84f9a93b4e1b /src/backend/nodes/outfuncs.c | |
| parent | 64974613c98e9928af7bbccaeb718012b1dc6769 (diff) | |
Code review for XML patch. Instill a bit of sanity in the location of
the XmlExpr code in various lists, use a representation that has some hope
of reverse-listing correctly (though it's still a de-escaping function
shy of correctness), generally try to make it look more like Postgres
coding conventions.
Diffstat (limited to 'src/backend/nodes/outfuncs.c')
| -rw-r--r-- | src/backend/nodes/outfuncs.c | 31 |
1 files changed, 16 insertions, 15 deletions
diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c index b18b6988cfa..4911d6ed404 100644 --- a/src/backend/nodes/outfuncs.c +++ b/src/backend/nodes/outfuncs.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.288 2006/12/23 00:43:10 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/outfuncs.c,v 1.289 2006/12/24 00:29:18 tgl Exp $ * * NOTES * Every node type that can appear in stored rules' parsetrees *must* @@ -893,6 +893,18 @@ _outMinMaxExpr(StringInfo str, MinMaxExpr *node) } static void +_outXmlExpr(StringInfo str, XmlExpr *node) +{ + WRITE_NODE_TYPE("XMLEXPR"); + + WRITE_ENUM_FIELD(op, XmlExprOp); + WRITE_STRING_FIELD(name); + WRITE_NODE_FIELD(named_args); + WRITE_NODE_FIELD(arg_names); + WRITE_NODE_FIELD(args); +} + +static void _outNullIfExpr(StringInfo str, NullIfExpr *node) { WRITE_NODE_TYPE("NULLIFEXPR"); @@ -923,17 +935,6 @@ _outBooleanTest(StringInfo str, BooleanTest *node) } static void -_outXmlExpr(StringInfo str, XmlExpr *node) -{ - WRITE_NODE_TYPE("XMLEXPR"); - - WRITE_ENUM_FIELD(op, XmlExprOp); - WRITE_STRING_FIELD(name); - WRITE_NODE_FIELD(named_args); - WRITE_NODE_FIELD(args); -} - -static void _outCoerceToDomain(StringInfo str, CoerceToDomain *node) { WRITE_NODE_TYPE("COERCETODOMAIN"); @@ -2026,6 +2027,9 @@ _outNode(StringInfo str, void *obj) case T_MinMaxExpr: _outMinMaxExpr(str, obj); break; + case T_XmlExpr: + _outXmlExpr(str, obj); + break; case T_NullIfExpr: _outNullIfExpr(str, obj); break; @@ -2035,9 +2039,6 @@ _outNode(StringInfo str, void *obj) case T_BooleanTest: _outBooleanTest(str, obj); break; - case T_XmlExpr: - _outXmlExpr(str, obj); - break; case T_CoerceToDomain: _outCoerceToDomain(str, obj); break; |