diff options
| author | Robert Haas <rhaas@postgresql.org> | 2012-02-13 22:20:27 -0500 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2012-02-13 22:21:14 -0500 |
| commit | cd30728fb2ed7c367d545fc14ab850b5fa2a4850 (patch) | |
| tree | c5d487f3abf9e5c66734db8ecb100f4442763822 /src/backend/optimizer/path/allpaths.c | |
| parent | 2bbd88f8f841b01efb073972b60d4dc1ff1f6fd0 (diff) | |
Allow LEAKPROOF functions for better performance of security views.
We don't normally allow quals to be pushed down into a view created
with the security_barrier option, but functions without side effects
are an exception: they're OK. This allows much better performance in
common cases, such as when using an equality operator (that might
even be indexable).
There is an outstanding issue here with the CREATE FUNCTION / ALTER
FUNCTION syntax: there's no way to use ALTER FUNCTION to unset the
leakproof flag. But I'm committing this as-is so that it doesn't
have to be rebased again; we can fix up the grammar in a future
commit.
KaiGai Kohei, with some wordsmithing by me.
Diffstat (limited to 'src/backend/optimizer/path/allpaths.c')
| -rw-r--r-- | src/backend/optimizer/path/allpaths.c | 11 |
1 files changed, 2 insertions, 9 deletions
diff --git a/src/backend/optimizer/path/allpaths.c b/src/backend/optimizer/path/allpaths.c index 19bf7340ad4..e99e4cc1761 100644 --- a/src/backend/optimizer/path/allpaths.c +++ b/src/backend/optimizer/path/allpaths.c @@ -1042,16 +1042,9 @@ set_subquery_pathlist(PlannerInfo *root, RelOptInfo *rel, RestrictInfo *rinfo = (RestrictInfo *) lfirst(l); Node *clause = (Node *) rinfo->clause; - /* - * XXX. You might wonder why we're testing rte->security_barrier - * qual-by-qual here rather than hoisting the test up into the - * surrounding if statement; after all, the answer will be the - * same for all quals. The answer is that we expect to shortly - * change this logic to allow pushing down some quals that use only - * "leakproof" operators even through a security barrier. - */ if (!rinfo->pseudoconstant && - !rte->security_barrier && + (!rte->security_barrier || + !contain_leaky_functions(clause)) && qual_is_pushdown_safe(subquery, rti, clause, differentTypes)) { /* Push it down */ |