summaryrefslogtreecommitdiff
path: root/src/backend/optimizer/util/relnode.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2017-09-06 10:41:05 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2017-09-06 10:41:05 -0400
commit483882905a9a5dc72c9487ceee12320b9630ba2b (patch)
treee1e3093c66dd2cac5d53236bcfd8982da234105f /src/backend/optimizer/util/relnode.c
parent3fbf09563f839137e5279a390044a18e400fa074 (diff)
Clean up handling of dropped columns in NAMEDTUPLESTORE RTEs.
The NAMEDTUPLESTORE patch piggybacked on the infrastructure for TABLEFUNC/VALUES/CTE RTEs, none of which can ever have dropped columns, so the possibility was ignored most places. Fix that, including adding a specification to parsenodes.h about what it's supposed to look like. In passing, clean up assorted comments that hadn't been maintained properly by said patch. Per bug #14799 from Philippe Beaudoin. Back-patch to v10. Discussion: https://postgr.es/m/20170906120005.25630.84360@wrigleys.postgresql.org
Diffstat (limited to 'src/backend/optimizer/util/relnode.c')
-rw-r--r--src/backend/optimizer/util/relnode.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c
index c8e2b67da42..7125082812a 100644
--- a/src/backend/optimizer/util/relnode.c
+++ b/src/backend/optimizer/util/relnode.c
@@ -178,8 +178,8 @@ build_simple_rel(PlannerInfo *root, int relid, RelOptInfo *parent)
case RTE_NAMEDTUPLESTORE:
/*
- * Subquery, function, tablefunc, or values list --- set up attr
- * range and arrays
+ * Subquery, function, tablefunc, values list, CTE, or ENR --- set
+ * up attr range and arrays
*
* Note: 0 is included in range to support whole-row Vars
*/