diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-04-04 11:13:17 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-04-04 11:13:26 -0400 |
commit | 3644ac04c1ea27e596b77b7a02609b50b4742403 (patch) | |
tree | 09ef705707317eb366d96b3feb9916fdb13e1225 /src/backend/parser/parse_expr.c | |
parent | c6d2fa1ab089110faee2810ef0fda1bccd4f1f6a (diff) |
Fix latent portability issue in pgwin32_dispatch_queued_signals().
The first iteration of the signal-checking loop would compute sigmask(0)
which expands to 1<<(-1) which is undefined behavior according to the
C standard. The lack of field reports of trouble suggest that it
evaluates to 0 on all existing Windows compilers, but that's hardly
something to rely on. Since signal 0 isn't a queueable signal anyway,
we can just make the loop iterate from 1 instead, and save a few cycles
as well as avoiding the undefined behavior.
In passing, avoid evaluating the volatile expression UNBLOCKED_SIGNAL_QUEUE
twice in a row; there's no reason to waste cycles like that.
Noted by Aleksander Alekseev, though this isn't his proposed fix.
Back-patch to all supported branches.
Diffstat (limited to 'src/backend/parser/parse_expr.c')
0 files changed, 0 insertions, 0 deletions