diff options
| author | Noah Misch <noah@leadboat.com> | 2019-08-05 07:48:41 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2019-08-05 07:48:45 -0700 |
| commit | 2062007cbf7008de383c8f2f4a9ad466ea243acf (patch) | |
| tree | be22380ea1fca698486d92445101e4dbed96e72b /src/backend/parser/parse_func.c | |
| parent | 5e32ae9d05d3b7e946cecc99bfa0c835dd108787 (diff) | |
Require the schema qualification in pg_temp.type_name(arg).
Commit aa27977fe21a7dfa4da4376ad66ae37cb8f0d0b5 introduced this
restriction for pg_temp.function_name(arg); do likewise for types
created in temporary schemas. Programs that this breaks should add
"pg_temp." schema qualification or switch to arg::type_name syntax.
Back-patch to 9.4 (all supported versions).
Reviewed by Tom Lane. Reported by Tom Lane.
Security: CVE-2019-10208
Diffstat (limited to 'src/backend/parser/parse_func.c')
| -rw-r--r-- | src/backend/parser/parse_func.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/backend/parser/parse_func.c b/src/backend/parser/parse_func.c index 25ae4e59490..571d3d1b62c 100644 --- a/src/backend/parser/parse_func.c +++ b/src/backend/parser/parse_func.c @@ -1769,7 +1769,12 @@ FuncNameAsType(List *funcname) Oid result; Type typtup; - typtup = LookupTypeName(NULL, makeTypeNameFromNameList(funcname), NULL, false); + /* + * temp_ok=false protects the <refsect1 id="sql-createfunction-security"> + * contract for writing SECURITY DEFINER functions safely. + */ + typtup = LookupTypeNameExtended(NULL, makeTypeNameFromNameList(funcname), + NULL, false, false); if (typtup == NULL) return InvalidOid; |