diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-11-05 03:05:05 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-11-05 03:05:05 +0000 |
| commit | 39edcf59a2534d0f59b29ebe0c6b94a3600d8c4b (patch) | |
| tree | c9a3a61c82432bb902e5c185c28d2e5510dd50bd /src/backend/postmaster/postmaster.c | |
| parent | 56f68ed9070794344a37f6c9414d421c4a04b898 (diff) | |
Repair an error introduced by log_line_prefix patch: it is not acceptable
to assume that the string pointer passed to set_ps_display is good forever.
There's no need to anyway since ps_status.c itself saves the string, and
we already had an API (get_ps_display) to return it.
I believe this explains Jim Nasby's report of intermittent crashes in
elog.c when %i format code is in use in log_line_prefix.
While at it, repair a previously unnoticed problem: on some platforms such as
Darwin, the string returned by get_ps_display was blank-padded to the maximum
length, meaning that lock.c's attempt to append " waiting" to it never worked.
Diffstat (limited to 'src/backend/postmaster/postmaster.c')
| -rw-r--r-- | src/backend/postmaster/postmaster.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c index 0a67a25916f..8b316197fc1 100644 --- a/src/backend/postmaster/postmaster.c +++ b/src/backend/postmaster/postmaster.c @@ -37,7 +37,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.443.4.3 2005/10/20 20:06:02 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.443.4.4 2005/11/05 03:05:04 tgl Exp $ * * NOTES * @@ -2638,7 +2638,6 @@ BackendRun(Port *port) /* set these to empty in case they are needed before we set them up */ port->remote_host = ""; port->remote_port = ""; - port->commandTag = ""; /* * Initialize libpq and enable reporting of ereport errors to the |