summaryrefslogtreecommitdiff
path: root/src/backend/postmaster/syslogger.c
diff options
context:
space:
mode:
authorMagnus Hagander <magnus@hagander.net>2012-02-21 17:12:25 +0100
committerMagnus Hagander <magnus@hagander.net>2012-02-21 17:14:27 +0100
commita863963fcdcc1d9cc3aac7e42ec696af4377cbc4 (patch)
treeedd83cdcdb87133543120579d0f75a04f97cda9a /src/backend/postmaster/syslogger.c
parentefe356110806f77508bb5d3ac6ec8682d7193356 (diff)
Avoid double close of file handle in syslogger on win32
This causes an exception when running under a debugger or in particular when running on a debug version of Windows. Patch from MauMau
Diffstat (limited to 'src/backend/postmaster/syslogger.c')
-rw-r--r--src/backend/postmaster/syslogger.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
index 3694fa57295..2e23d3199c2 100644
--- a/src/backend/postmaster/syslogger.c
+++ b/src/backend/postmaster/syslogger.c
@@ -593,8 +593,11 @@ SysLogger_Start(void)
errmsg("could not redirect stderr: %m")));
close(fd);
_setmode(_fileno(stderr), _O_BINARY);
- /* Now we are done with the write end of the pipe. */
- CloseHandle(syslogPipe[1]);
+ /*
+ * Now we are done with the write end of the pipe.
+ * CloseHandle() must not be called because the preceding
+ * close() closes the underlying handle.
+ */
syslogPipe[1] = 0;
#endif
redirection_done = true;