diff options
| author | Amit Kapila <akapila@postgresql.org> | 2023-05-03 10:13:13 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2023-05-03 10:17:49 +0530 |
| commit | de63f8dadee4afa152ce177fd3c562d47373a728 (patch) | |
| tree | 0d0dc49ae8ee5dded48eeb1e1594f2ceb2c708f4 /src/backend/replication/logical/applyparallelworker.c | |
| parent | 6489875ce6b16662142bc70e003437b9753c199f (diff) | |
Fix assertion failure in apply worker.
During exit, the logical replication apply worker tries to release session
level locks, if any. However, if the apply worker exits due to an error
before its connection is initialized, trying to release locks can lead to
assertion failure. The locks will be acquired once the worker is
initialized, so we don't need to release them till the worker
initialization is complete.
Reported-by: Alexander Lakhin
Author: Hou Zhijie based on inputs from Sawada Masahiko and Amit Kapila
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/2185d65f-5aae-3efa-c48f-fb42b173ef5c@gmail.com
Diffstat (limited to 'src/backend/replication/logical/applyparallelworker.c')
| -rw-r--r-- | src/backend/replication/logical/applyparallelworker.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/backend/replication/logical/applyparallelworker.c b/src/backend/replication/logical/applyparallelworker.c index 45186837795..ee7a18137fc 100644 --- a/src/backend/replication/logical/applyparallelworker.c +++ b/src/backend/replication/logical/applyparallelworker.c @@ -873,6 +873,8 @@ ParallelApplyWorkerMain(Datum main_arg) int worker_slot = DatumGetInt32(main_arg); char originname[NAMEDATALEN]; + InitializingApplyWorker = true; + /* Setup signal handling. */ pqsignal(SIGHUP, SignalHandlerForConfigReload); pqsignal(SIGINT, SignalHandlerForShutdownRequest); @@ -940,6 +942,8 @@ ParallelApplyWorkerMain(Datum main_arg) InitializeApplyWorker(); + InitializingApplyWorker = false; + /* Setup replication origin tracking. */ StartTransactionCommand(); ReplicationOriginNameForLogicalRep(MySubscription->oid, InvalidOid, |