diff options
| author | Peter Geoghegan <pg@bowt.ie> | 2022-09-17 17:20:17 -0700 |
|---|---|---|
| committer | Peter Geoghegan <pg@bowt.ie> | 2022-09-17 17:20:17 -0700 |
| commit | 035ce1feb2ed27680558ebc5cd1455041c8ec3cf (patch) | |
| tree | f3dfc46d58cf6e9d71d5596c4079ae276faaf661 /src/backend/replication/logical/reorderbuffer.c | |
| parent | 4274dc223ce75b2adf7b7cde5e00df7bbdd2a061 (diff) | |
Harmonize reorderbuffer parameter names.
Make reorderbuffer.h function declarations consistently use named
parameters. Also make sure that the declarations use names that match
corresponding names from function definitions in reorderbuffer.c. This
makes the definitions easier to follow, especially in the case of
functions that happen to have adjoining arguments of the same type.
This patch was written with help from clang-tidy. Specifically, its
"readability-inconsistent-declaration-parameter-name" check and its
"readability-named-parameter" check were used.
Author: Peter Geoghegan <pg@bowt.ie>
Discussion: https://postgr.es/m/3955318.1663377656@sss.pgh.pa.us
Diffstat (limited to 'src/backend/replication/logical/reorderbuffer.c')
| -rw-r--r-- | src/backend/replication/logical/reorderbuffer.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 89cf9f9389c..03d9c9c86a2 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -250,7 +250,7 @@ static void ReorderBufferSerializeChange(ReorderBuffer *rb, ReorderBufferTXN *tx static Size ReorderBufferRestoreChanges(ReorderBuffer *rb, ReorderBufferTXN *txn, TXNEntryFile *file, XLogSegNo *segno); static void ReorderBufferRestoreChange(ReorderBuffer *rb, ReorderBufferTXN *txn, - char *change); + char *data); static void ReorderBufferRestoreCleanup(ReorderBuffer *rb, ReorderBufferTXN *txn); static void ReorderBufferTruncateTXN(ReorderBuffer *rb, ReorderBufferTXN *txn, bool txn_prepared); @@ -820,7 +820,7 @@ ReorderBufferQueueChange(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn, */ void ReorderBufferQueueMessage(ReorderBuffer *rb, TransactionId xid, - Snapshot snapshot, XLogRecPtr lsn, + Snapshot snap, XLogRecPtr lsn, bool transactional, const char *prefix, Size message_size, const char *message) { @@ -847,7 +847,7 @@ ReorderBufferQueueMessage(ReorderBuffer *rb, TransactionId xid, else { ReorderBufferTXN *txn = NULL; - volatile Snapshot snapshot_now = snapshot; + volatile Snapshot snapshot_now = snap; if (xid != InvalidTransactionId) txn = ReorderBufferTXNByXid(rb, xid, true, NULL, lsn, true); |